Improve Doctrine integration Fix #146, #152 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadikoff
changed the title
sadikoff
changed the title
weaverryan
requested changes
Apr 18, 2018
| $this->fileManager = $fileManager; | ||
| $this->generator = $generator; | ||
| $this->projectDirectory = $projectDirectory; | ||
| $this->overwrite = $overwrite; | ||
| $this->metadataFactory = new DoctrineMetadataFactory($this->doctrineRegistry); |
There was a problem hiding this comment.
The DoctrineMetadataFactory calls should be deleted entirely now, correct?
There was a problem hiding this comment.
yes, and DoctrineMetadataFactory class too I think
src/Doctrine/DoctrineHelper.php
Outdated
| * | ||
| * @throws \Exception | ||
| */ | ||
| public function createDoctrineDetails(string $entityClassName) |
There was a problem hiding this comment.
you can use a return type here instead of @returns
src/Doctrine/DoctrineHelper.php
Outdated
| return $entities; | ||
| } | ||
|
|
||
| public function getMetadata(string $classOrNamespace = null, bool $disconnected = false) |
| /** | ||
| * @ORM\Column(type="string", length=255) | ||
| */ | ||
| private $ingridients; |
weaverryan
force-pushed
the
doctrine-inheritance-bugfix
branch
from
420f8f1
to
7b8ac42
Compare
|
Very nice, very careful work. Thank you @sadikoff! |
|
@weaverryan I think this introduced a bug: Undefined class constant 'ONE_TO_MANY' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #146
in progress...